dump1090 crash (bug)


#1

I have been playing with getting dump1090 working through a reverse proxy so I can monitor it remotely. However, it looks like there is a bug that caused it to segfault if you request a URL that it can’t serve. It really should just return a 404 error rather than crash.

My proxy wasn’t set up properly and was requesting /piware from port 8080. Running an strace on dump1090 shows that it got a ENOENT then threw a segv.

highly filtered strace output follows:



[pid  3434] read(15, "GET /piaware HTTP/1.0
Host: www"..., 1024) = 368
[pid  3434] stat64("/usr/share/dump1090/public_html//piaware", 0xbee744a0) = -1 ENOENT (No such file or directory)
[pid  3434] --- SIGSEGV (Segmentation fault) @ 0 (0) ---



Monitoring PIAware status?
#2

I believe that issue should be fixed within the upstream dump1090 when this patch gets accepted:
github.com/MalcolmRobb/dump1090/pull/38


#3

Great! That also answers my question of whether or not you and/or Malcolm accept pull requests. I was going to fork the repo to add the --make-pidfile argument to the dump1090 start script.